Stop using Label.workspace_name #4282
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
fmeum
approved these changes
Feb 24, 2025
According to the Bazel documentation, it is deprecated. Label.repo_name should be used instead. https://bazel.build/rules/lib/builtins/Label#workspace_name
fmeum
force-pushed
the
eschouten/20250217-repo-name
branch
from
38fe4be to
af60cb3
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
What type of PR is this?
Other
What does this PR do? Why is it needed?
According to the Bazel documentation, it is deprecated. Label.repo_name should be used instead.
https://bazel.build/rules/lib/builtins/Label#workspace_name
Which issues(s) does this PR fix?
I am working on an analysis tool for Bazel BUILD/*.bzl files. It is currently unable to process Label.workspace_name. Adding support for it is trivial, however I thought it would be a good idea to fix up existing rules instead.
Other notes for review