go_sdk: Pick a consistent repo name to improve cachability #4314
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
The SDK's repo name will be part of the builder path and as such part of every compile/linking action. Pick a generic name for the root module to allow caching these actions across modules. This change assumes that every module other than the root module will have a name. Fixes bazel-contrib#4312
fmeum
approved these changes
Apr 10, 2025
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
The SDK's repo name will be part of the builder path and as such part of every compile/linking action. Pick a generic name for the root module to allow caching these actions across modules.
This change assumes that every module other than the root module will have a name.
Fixes #4312
What type of PR is this?
Bug fix
What does this PR do? Why is it needed?
Pick the same repo name for the SDK download across different root modules. This matters as every compilation/linking will be done through the builder and the repo name is part of the path to the builder. After this change the path will be consistent across different root modules.
Which issues(s) does this PR fix?
Fixes #4312
Other notes for review
This code assumes that every non-root module has a name (e.g. imported via a bazel_dep).