-
Notifications
You must be signed in to change notification settings - Fork 68
fix: BazelJUnitOutputListener logging xml output on suite-level failures #328
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Conversation
my hot take: I wrote some tests that work on actual test classes rather than The unit tests on TestData only take us so far; we need to write more "integration-style" tests running on real classes IMO since the JUnit data structure is kind of opaque. |
@fzakaria, I've no objection to a very limited number of test cases like this, but they tend to be slow to run, require a lot more set up, and can be opaque to debug and understand. If we introduce them, I'd rather they were an absolute minority of tests for this kind of functionality. |
@shs96c i agree hollistically but the JUnit stuff is so opaque -- feels like starting in the reverse direction is good. Anyways -- just my thoughts. As someone who likes to contribute this can help me understand if I'm breaking other consumers. |
@shs96c Can you please take a look |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM, but could you please run bazel run scripts:format
?
@shs96c Can you please merge it. I have fixed formatting issue. |
fixes: #327