Allow setting wrapper targets based on annotations #79
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
illicitonion
force-pushed
the
annotations-for-wrappers
branch
from
f220ae6 to
6e72483
Compare
|
Closing this for now - will revive if it becomes necessary |
illicitonion
force-pushed
the
annotations-for-wrappers
branch
from
6e72483 to
17f9973
Compare
illicitonion
force-pushed
the
annotations-for-wrappers
branch
from
17f9973 to
bbb48f6
Compare
This allows for registering that, e.g.
```java
@RequiresNetwork
class SomeTest {}
```
should be generated as:
```starlark
requires_network(
java_test,
...
)
```
instead of:
```starlark
java_test(
...
)
```
In suite mode, separate targets will be generated for these special
targets.
illicitonion
force-pushed
the
annotations-for-wrappers
branch
from
bbb48f6 to
1a790aa
Compare
stevebarrau
approved these changes
Jan 23, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This allows for registering that, e.g.
should be generated as:
instead of:
java_test( ... )In suite mode, separate targets will be generated for these special
targets.