Handle multiple queries at once #57
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
The documentation says that this action can handle multiple queries passed into it when separated with a `|`, but it looks like that wasn't actually implemented anywhere. This enables that behavior.
|
There might be a more robust way to handle this, and the additional creation of a list at L#190 isn't strictly necessary, but it gets the job done without cluttering up the |
|
Sorry for the delay. Thanks for this. I'm happy to merge as is, but if I would love to some how move this logic into an abstraction layer so that deconz-specific logic is abstracted away from the procedural code. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
The documentation says that this action can handle multiple queries passed into it when separated with a
|, but it looks like that wasn't actually implemented anywhere. This enables that behavior, and (should) resolve #51.