feat(payment): Refactor code in order to use newly added skipRedirect… #2900
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…ConfirmationAlert
🎉 Snyk checks have passed. No issues have been found so far.✅ code/snyk check is complete. No issues have been found. (View Details) |
vitalii-koshovyi
approved these changes
Jun 19, 2025
bc-nick
approved these changes
Jun 23, 2025
bc-peng
reviewed
Jun 23, 2025
| @@ -14,4 +14,5 @@ export default interface PaymentMethod<T = any> { | |||
| initializationData?: T; | |||
| returnUrl?: string; | |||
| initializationStrategy?: InitializationStrategy; | |||
| skipRedirectConfirmationAlert: boolean; | |||
There was a problem hiding this comment.
I see this interface is being used a lot in checkout-js.
Did you test this version of SDK in checkout-js?
There was a problem hiding this comment.
Yes, and I will also test it with all affected payment providers in checkout-js PR
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
…ConfirmationAlert
What/Why?
In this PR the
PaymentMethodinterface and mocks are updated to meet newskipRedirectConfirmationAlertproperty requirement.skipRedirectConfirmationAlertis boolean and is not optional.Checkout-js part bigcommerce/checkout-js#2374 <-- more context in PR description
BCAPP part https://github.com/bigcommerce/bigcommerce/pull/63372
Testing / Proof
Tested manually
@bigcommerce/team-checkout @bigcommerce/team-payments