Skip to content
This repository was archived by the owner on Jun 10, 2024. It is now read-only.

modify async to async_mode to support python3.7 #836

Merged
merged 8 commits into from
Feb 24, 2019

Conversation

farmercode
Copy link
Contributor

support python3.7

@philtrade philtrade mentioned this pull request Nov 1, 2018
@PhillipPeterson
Copy link

Since you were already on supporting 3.7 is it doable to add 3.7 that to the travis ci file?

@farmercode
Copy link
Contributor Author

I'm new to continuous integration,I add py3.7-dev to travis ci file!And the test passed! Is this ok?

@PhillipPeterson
Copy link

I'm new to it as well! With all the tests passing I think it's good, thank you!

@vinsec
Copy link
Contributor

vinsec commented Feb 18, 2019

of course it wasn't a total replacement in #803 ,I pulled a request and replaced the rest args but failed in travis checks.At least, there is all ok now in my server with python 3.7.

@binux binux merged commit 329cadb into binux:master Feb 24, 2019
@gitfourteen
Copy link

gitfourteen commented Nov 25, 2019

Problem still exits. macOS Catalina, Python 3.7.5, pipenv
Tried to replace with async with something likeaync_spider. It seem an endless job and errors popping out again and again. First time to use PySpider...

Finally got this. ``` [W 191125 16:51:27 run:413] phantomjs not found, continue running without it. [I 191125 16:51:29 result_worker:49] result_worker starting... [I 191125 16:51:30 scheduler:647] scheduler starting... [I 191125 16:51:30 processor:211] processor starting... [I 191125 16:51:30 scheduler:782] scheduler.xmlrpc listening on 127.0.0.1:23333 [I 191125 16:51:30 scheduler:586] in 5m: new:0,success:0,retry:0,failed:0 [I 191125 16:51:31 tornado_fetcher:638] fetcher starting... [I 191125 16:51:31 app:84] webui exiting... Traceback (most recent call last): File "/Users/rindt/.local/share/virtualenvs/PySpider-Hw_U5HLL/bin/pyspider", line 8, in sys.exit(main()) File "/Users/rindt/.local/share/virtualenvs/PySpider-Hw_U5HLL/lib/python3.7/site-packages/pyspider/run.py", line 754, in main cli() File "/Users/rindt/.local/share/virtualenvs/PySpider-Hw_U5HLL/lib/python3.7/site-packages/click/core.py", line 764, in __call__ return self.main(*args, **kwargs) File "/Users/rindt/.local/share/virtualenvs/PySpider-Hw_U5HLL/lib/python3.7/site-packages/click/core.py", line 717, in main rv = self.invoke(ctx) File "/Users/rindt/.local/share/virtualenvs/PySpider-Hw_U5HLL/lib/python3.7/site-packages/click/core.py", line 1114, in invoke return Command.invoke(self, ctx) File "/Users/rindt/.local/share/virtualenvs/PySpider-Hw_U5HLL/lib/python3.7/site-packages/click/core.py", line 956, in invoke return ctx.invoke(self.callback, **ctx.params) File "/Users/rindt/.local/share/virtualenvs/PySpider-Hw_U5HLL/lib/python3.7/site-packages/click/core.py", line 555, in invoke return callback(*args, **kwargs) File "/Users/rindt/.local/share/virtualenvs/PySpider-Hw_U5HLL/lib/python3.7/site-packages/click/decorators.py", line 17, in new_func return f(get_current_context(), *args, **kwargs) File "/Users/rindt/.local/share/virtualenvs/PySpider-Hw_U5HLL/lib/python3.7/site-packages/pyspider/run.py", line 165, in cli ctx.invoke(all) File "/Users/rindt/.local/share/virtualenvs/PySpider-Hw_U5HLL/lib/python3.7/site-packages/click/core.py", line 555, in invoke return callback(*args, **kwargs) File "/Users/rindt/.local/share/virtualenvs/PySpider-Hw_U5HLL/lib/python3.7/site-packages/click/decorators.py", line 17, in new_func return f(get_current_context(), *args, **kwargs) File "/Users/rindt/.local/share/virtualenvs/PySpider-Hw_U5HLL/lib/python3.7/site-packages/pyspider/run.py", line 497, in all ctx.invoke(webui, **webui_config) File "/Users/rindt/.local/share/virtualenvs/PySpider-Hw_U5HLL/lib/python3.7/site-packages/click/core.py", line 555, in invoke return callback(*args, **kwargs) File "/Users/rindt/.local/share/virtualenvs/PySpider-Hw_U5HLL/lib/python3.7/site-packages/click/decorators.py", line 17, in new_func return f(get_current_context(), *args, **kwargs) File "/Users/rindt/.local/share/virtualenvs/PySpider-Hw_U5HLL/lib/python3.7/site-packages/pyspider/run.py", line 384, in webui app.run(host=host, port=port) File "/Users/rindt/.local/share/virtualenvs/PySpider-Hw_U5HLL/lib/python3.7/site-packages/pyspider/webui/app.py", line 59, in run from .webdav import dav_app File "/Users/rindt/.local/share/virtualenvs/PySpider-Hw_U5HLL/lib/python3.7/site-packages/pyspider/webui/webdav.py", line 216, in dav_app = WsgiDAVApp(config) File "/Users/rindt/.local/share/virtualenvs/PySpider-Hw_U5HLL/lib/python3.7/site-packages/wsgidav/wsgidav_app.py", line 134, in __init__ _check_config(config) File "/Users/rindt/.local/share/virtualenvs/PySpider-Hw_U5HLL/lib/python3.7/site-packages/wsgidav/wsgidav_app.py", line 118, in _check_config raise ValueError("Invalid configuration:\n - " + "\n - ".join(errors)) ValueError: Invalid configuration: - Deprecated option 'domaincontroller': use 'http_authenticator.domain_controller' instead. ```

And addressed above issue following this solution

Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

5 participants