This repository was archived by the owner on Jun 10, 2024. It is now read-only.
-
Notifications
You must be signed in to change notification settings - Fork 3.7k
modify async to async_mode to support python3.7 #836
Merged
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Merged
Since you were already on supporting 3.7 is it doable to add 3.7 that to the travis ci file? |
I'm new to continuous integration,I add py3.7-dev to travis ci file!And the test passed! Is this ok? |
I'm new to it as well! With all the tests passing I think it's good, thank you! |
of course it wasn't a total replacement in #803 ,I pulled a request and replaced the rest args but failed in travis checks.At least, there is all ok now in my server with python 3.7. |
Problem still exits. Finally got this.``` [W 191125 16:51:27 run:413] phantomjs not found, continue running without it. [I 191125 16:51:29 result_worker:49] result_worker starting... [I 191125 16:51:30 scheduler:647] scheduler starting... [I 191125 16:51:30 processor:211] processor starting... [I 191125 16:51:30 scheduler:782] scheduler.xmlrpc listening on 127.0.0.1:23333 [I 191125 16:51:30 scheduler:586] in 5m: new:0,success:0,retry:0,failed:0 [I 191125 16:51:31 tornado_fetcher:638] fetcher starting... [I 191125 16:51:31 app:84] webui exiting... Traceback (most recent call last): File "/Users/rindt/.local/share/virtualenvs/PySpider-Hw_U5HLL/bin/pyspider", line 8, in sys.exit(main()) File "/Users/rindt/.local/share/virtualenvs/PySpider-Hw_U5HLL/lib/python3.7/site-packages/pyspider/run.py", line 754, in main cli() File "/Users/rindt/.local/share/virtualenvs/PySpider-Hw_U5HLL/lib/python3.7/site-packages/click/core.py", line 764, in __call__ return self.main(*args, **kwargs) File "/Users/rindt/.local/share/virtualenvs/PySpider-Hw_U5HLL/lib/python3.7/site-packages/click/core.py", line 717, in main rv = self.invoke(ctx) File "/Users/rindt/.local/share/virtualenvs/PySpider-Hw_U5HLL/lib/python3.7/site-packages/click/core.py", line 1114, in invoke return Command.invoke(self, ctx) File "/Users/rindt/.local/share/virtualenvs/PySpider-Hw_U5HLL/lib/python3.7/site-packages/click/core.py", line 956, in invoke return ctx.invoke(self.callback, **ctx.params) File "/Users/rindt/.local/share/virtualenvs/PySpider-Hw_U5HLL/lib/python3.7/site-packages/click/core.py", line 555, in invoke return callback(*args, **kwargs) File "/Users/rindt/.local/share/virtualenvs/PySpider-Hw_U5HLL/lib/python3.7/site-packages/click/decorators.py", line 17, in new_func return f(get_current_context(), *args, **kwargs) File "/Users/rindt/.local/share/virtualenvs/PySpider-Hw_U5HLL/lib/python3.7/site-packages/pyspider/run.py", line 165, in cli ctx.invoke(all) File "/Users/rindt/.local/share/virtualenvs/PySpider-Hw_U5HLL/lib/python3.7/site-packages/click/core.py", line 555, in invoke return callback(*args, **kwargs) File "/Users/rindt/.local/share/virtualenvs/PySpider-Hw_U5HLL/lib/python3.7/site-packages/click/decorators.py", line 17, in new_func return f(get_current_context(), *args, **kwargs) File "/Users/rindt/.local/share/virtualenvs/PySpider-Hw_U5HLL/lib/python3.7/site-packages/pyspider/run.py", line 497, in all ctx.invoke(webui, **webui_config) File "/Users/rindt/.local/share/virtualenvs/PySpider-Hw_U5HLL/lib/python3.7/site-packages/click/core.py", line 555, in invoke return callback(*args, **kwargs) File "/Users/rindt/.local/share/virtualenvs/PySpider-Hw_U5HLL/lib/python3.7/site-packages/click/decorators.py", line 17, in new_func return f(get_current_context(), *args, **kwargs) File "/Users/rindt/.local/share/virtualenvs/PySpider-Hw_U5HLL/lib/python3.7/site-packages/pyspider/run.py", line 384, in webui app.run(host=host, port=port) File "/Users/rindt/.local/share/virtualenvs/PySpider-Hw_U5HLL/lib/python3.7/site-packages/pyspider/webui/app.py", line 59, in run from .webdav import dav_app File "/Users/rindt/.local/share/virtualenvs/PySpider-Hw_U5HLL/lib/python3.7/site-packages/pyspider/webui/webdav.py", line 216, in dav_app = WsgiDAVApp(config) File "/Users/rindt/.local/share/virtualenvs/PySpider-Hw_U5HLL/lib/python3.7/site-packages/wsgidav/wsgidav_app.py", line 134, in __init__ _check_config(config) File "/Users/rindt/.local/share/virtualenvs/PySpider-Hw_U5HLL/lib/python3.7/site-packages/wsgidav/wsgidav_app.py", line 118, in _check_config raise ValueError("Invalid configuration:\n - " + "\n - ".join(errors)) ValueError: Invalid configuration: - Deprecated option 'domaincontroller': use 'http_authenticator.domain_controller' instead. ```And addressed above issue following this solution |
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
support python3.7