[ENH] dictyExpress: Time as ContinuousVariable #343
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
JakaKokosar
requested changes
Aug 28, 2023
Co-authored-by: Jaka <[email protected]>
JakaKokosar
changed the title
JakaKokosar
changed the title
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Issue
When trying to use dictyExpress as a data source to compare the new data with published data, there is an error. The problem seems to be that the Time column is a String Variable and therefore its PCA cannot be applied to newer data. Editing the domain (so that Time is numeric variable) doesn't seem to fix the issue. Here is a screenshot of the problem.
Description of changes
I propose changing the code so that Time is set as a ContinuousVariable. I also fixed the bug that prevented the dictyExpress from loading (if isinstance(type(row[label[0]]["value"]), list): --> if isinstance(row[label[0]]["value"], list):).
Includes