Bump php version to 7.2 #114
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
Could you please revert the change in the Changelog file? I will update it once the new version will be released. Otherwise you will confuse me. And you do not want to confuse me, trust me. |
|
Aaaaaaaaaaaaaand it's gone. |
|
Thank you for your contribution! |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
As #111 already targets compatibility to PHP 7.2, I provide a PR that bumps the minimum version in Composer to PHP 7.2 using the current ProxyManager version.
There are no new updates for return types needed, but I saw that not every method in Disco seems to have a return type. Should I add them in this PR, introducing BC breaks?