[WIP] Revise the documentation #92
Closed
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
The intent here is to make it that much easier to read. There were a few typos and grammar mistakes. But the main thing that I focused on was readability. I hope that this helps.
|
We probably should add the "Why Disco?" part to the README.md file to give a better impression why Disco as a DI container does make sense. |
| Disco needs at least [PHP](http://php.net) 7.0 since Disco relies on the | ||
| [return type declarations](http://php.net/manual/en/functions.returning-values.php#functions.returning-values.type-declaration) | ||
| feature introduced with PHP 7.0. | ||
| Disco needs at least [PHP](http://php.net) 7.0, as Disco relies on the [return type declarations](http://php.net/manual/en/functions.returning-values.php#functions.returning-values.type-declaration) feature introduced with PHP 7.0. |
There was a problem hiding this comment.
That would be PHP 7.1 by now.
|
@settermjd is this PR still needed? |
|
At this stage, since it's been so long, I'm going to scrap them and potentially look again at them. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
The intent here is to make it that much easier to read. There were a few typos and grammar mistakes. But the main thing that I focused on was readability. I hope that this helps.