-
Notifications
You must be signed in to change notification settings - Fork 5.6k
Add vhost --default-queue-type option #82763
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Conversation
Signed-off-by: alborzjafari <[email protected]>
0fe0be6
to
8d210eb
Compare
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Nice! thanks a lot for your contribution @alborzjafari
LGTM, but I've just seen there is no default_queue_type
in the rabbitmq.conf
file we are generating. I think is worth to add default_queue_type
feature in both places:
- For the virtual hosts as you have done here.
- For the node with
default_queue_type
in therabbitmq.conf
.
Probably you have more context than me about that rabbitmq feature, could you add the last part? if not, there is no problem, I am happy to accept this PR as it is right now.
Signed-off-by: alborzjafari <[email protected]>
Thanks a lot for the feedback! 🙌 |
Signed-off-by: alborzjafari <[email protected]>
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM
Thanks a lot for your contribution @alborzjafari
You're welcome, and thanks for accepting the PR @fmulero |
Description of the change
--default-queue-type
option as described in the documentation.Benefits
In some cases (including mine), it is not possible to change the default queue type from the application source code; therefore, it should be changed in the RabbitMQ configuration.
Possible drawbacks
There are no limitations introduced by this change.