Skip to content

Add vhost --default-queue-type option #82763

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 3 commits into from
Jul 2, 2025

Conversation

alborzjafari
Copy link
Contributor

Description of the change

  • This commit adds the --default-queue-type option as described in the documentation.
  • To test the change, set the RABBITMQ_VHOSTS environment variable. For example:
    RABBITMQ_VHOSTS=queue_name_0:classic queue_name_1:quorum queue_name_2:stream
    
  • If a queue name is specified without a queue type, it will use the default type:
    RABBITMQ_VHOSTS=queue_name_0 queue_name_1:quorum
    

Benefits

In some cases (including mine), it is not possible to change the default queue type from the application source code; therefore, it should be changed in the RabbitMQ configuration.

Possible drawbacks

There are no limitations introduced by this change.

@github-actions github-actions bot added rabbitmq triage Triage is needed labels Jun 29, 2025
@github-actions github-actions bot requested a review from carrodher June 29, 2025 10:41
@alborzjafari alborzjafari force-pushed the add-default-queue-type branch from 0fe0be6 to 8d210eb Compare June 29, 2025 10:43
@carrodher carrodher added verify Execute verification workflow for these changes in-progress labels Jun 29, 2025
@github-actions github-actions bot removed the triage Triage is needed label Jun 29, 2025
@github-actions github-actions bot removed the request for review from carrodher June 29, 2025 17:11
@github-actions github-actions bot requested a review from fmulero June 29, 2025 17:11
Copy link
Collaborator

@fmulero fmulero left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Nice! thanks a lot for your contribution @alborzjafari

LGTM, but I've just seen there is no default_queue_type in the rabbitmq.conf file we are generating. I think is worth to add default_queue_type feature in both places:

  • For the virtual hosts as you have done here.
  • For the node with default_queue_type in the rabbitmq.conf.

Probably you have more context than me about that rabbitmq feature, could you add the last part? if not, there is no problem, I am happy to accept this PR as it is right now.

@alborzjafari
Copy link
Contributor Author

@fmulero

Thanks a lot for the feedback! 🙌
You're right — good point about default_queue_type in rabbitmq.conf. I've added that in the second commit. Let me know if there's anything else you'd like adjusted!

Copy link
Collaborator

@fmulero fmulero left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

Thanks a lot for your contribution @alborzjafari

@fmulero fmulero merged commit bc1e508 into bitnami:main Jul 2, 2025
9 checks passed
@alborzjafari
Copy link
Contributor Author

You're welcome, and thanks for accepting the PR @fmulero

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
rabbitmq solved verify Execute verification workflow for these changes
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants