-
Notifications
You must be signed in to change notification settings - Fork 29
implement view pages #102
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Open
GamerGirlandCo
wants to merge
13
commits into
master
Choose a base branch
from
feat/view-pages
base: master
Could not load branches
Branch not found: {{ refName }}
Loading
Could not load tags
Nothing to show
Loading
Are you sure you want to change the base?
Some commits from the old base branch may be removed from the timeline,
and old review comments may become outdated.
Open
implement view pages #102
Changes from all commits
Commits
Show all changes
13 commits
Select commit
Hold shift + click to select a range
88fc6dc
create a `useAsync` hook and a companion `Suspend` component
GamerGirlandCo 2be4170
add `loader` parameter to `useEffect` dependencies
GamerGirlandCo da3a945
make `Suspend` fallback prettier
GamerGirlandCo ac9deda
update `useAsync` to be more resilient to race conditions
GamerGirlandCo e68301f
expose `SETTINGS_CONTEXT`, `COMPONENT_CONTEXT`, `DATACORE_CONTEXT` an…
GamerGirlandCo 96f4b2a
add ability to create views for queries that are treated like any oth…
GamerGirlandCo 35e9fd0
upgrade react-select to silence typescript errors
GamerGirlandCo e463829
re-add vim codemirror plugin
GamerGirlandCo 4abd313
re-add missing autocomplete and javascript language codemirror plugins
GamerGirlandCo 1dfe947
add more dev deps to appease typescript
GamerGirlandCo 07215de
bring `@codemirror/view` up to date
GamerGirlandCo 9ae4d7f
silence more bogus errors
GamerGirlandCo b89038f
move select augmentation to proper folder, re-export some things
GamerGirlandCo File filter
Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
There are no files selected for viewing
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Original file line number | Diff line number | Diff line change |
---|---|---|
|
@@ -9,14 +9,14 @@ import { IndexQuery } from "index/types/index-query"; | |
import { Indexable } from "index/types/indexable"; | ||
import { MarkdownPage } from "index/types/markdown"; | ||
import { App } from "obsidian"; | ||
import { useFileMetadata, useFullQuery, useIndexUpdates, useInterning, useQuery } from "ui/hooks"; | ||
import { useAsync, useFileMetadata, useFullQuery, useIndexUpdates, useInterning, useQuery } from "ui/hooks"; | ||
import * as luxon from "luxon"; | ||
import * as preact from "preact"; | ||
import * as hooks from "preact/hooks"; | ||
import { Result } from "./result"; | ||
import { Group, Stack } from "./ui/layout"; | ||
import { Embed, LineSpanEmbed } from "api/ui/embed"; | ||
import { CURRENT_FILE_CONTEXT, ErrorMessage, Lit, Markdown, ObsidianLink } from "ui/markdown"; | ||
import { APP_CONTEXT, COMPONENT_CONTEXT, CURRENT_FILE_CONTEXT, DATACORE_CONTEXT, ErrorMessage, Lit, Markdown, ObsidianLink, SETTINGS_CONTEXT } from "ui/markdown"; | ||
import { CSSProperties } from "preact/compat"; | ||
import { Literal, Literals } from "expression/literal"; | ||
import { Button, Checkbox, Icon, Slider, Switch, Textbox, VanillaSelect } from "./ui/basics"; | ||
|
@@ -188,6 +188,25 @@ export class DatacoreLocalApi { | |
/** Execute a textual or typed index query, returning results plus performance metadata. */ | ||
public tryFullQuery(query: string | IndexQuery): Result<SearchResult<Indexable>, string> { | ||
return this.api.tryFullQuery(query); | ||
} | ||
////////////// | ||
// Contexts // | ||
////////////// | ||
|
||
// export the necessary contexts to enable rendering | ||
// datacore components outside the datacore plugin | ||
// itself | ||
get SETTINGS_CONTEXT(): typeof SETTINGS_CONTEXT { | ||
return SETTINGS_CONTEXT; | ||
} | ||
get COMPONENT_CONTEXT(): typeof COMPONENT_CONTEXT { | ||
return COMPONENT_CONTEXT; | ||
} | ||
get DATACORE_CONTEXT(): typeof DATACORE_CONTEXT { | ||
return DATACORE_CONTEXT; | ||
} | ||
get APP_CONTEXT(): typeof APP_CONTEXT { | ||
return APP_CONTEXT; | ||
} | ||
|
||
///////////// | ||
|
@@ -218,6 +237,7 @@ export class DatacoreLocalApi { | |
* React's reference-equality-based caching. | ||
*/ | ||
public useInterning = useInterning; | ||
public useAsync = useAsync; | ||
|
||
/** Memoize the input automatically and process it using a DataArray; returns a vanilla array back. */ | ||
public useArray<T, U>(input: T[] | DataArray<T>, process: (data: DataArray<T>) => DataArray<U>, deps?: any[]): U[] { | ||
|
@@ -267,6 +287,31 @@ export class DatacoreLocalApi { | |
/** Horizontal flexbox container; good for putting items together in a row. */ | ||
public Group = Group; | ||
|
||
/** A component that only renders its children if `loaded` is true, otherwise defaulting to the `fallback` prop. | ||
* Primarily intended to be used with `useAsync`. | ||
*/ | ||
public Suspend({ | ||
loaded: loaded, | ||
There was a problem hiding this comment. Choose a reason for hiding this commentThe reason will be displayed to describe this comment to others. Learn more. Un-neccessary |
||
children, | ||
fallback, | ||
}: { | ||
loaded: boolean; | ||
children: preact.ComponentChildren; | ||
fallback: preact.ComponentChild; | ||
}) { | ||
return ( | ||
<> | ||
{loaded ? ( | ||
children | ||
) : ( | ||
<div className="datacore-loading-boundary"> | ||
<div className="datacore-loading-content">{fallback}</div> | ||
</div> | ||
)} | ||
</> | ||
); | ||
} | ||
|
||
/** Renders a literal value in a pretty way that respects settings. */ | ||
public Literal = (({ value, sourcePath, inline }: { value: Literal; sourcePath?: string; inline?: boolean }) => { | ||
const implicitSourcePath = hooks.useContext(CURRENT_FILE_CONTEXT); | ||
|
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Original file line number | Diff line number | Diff line change |
---|---|---|
|
@@ -3,6 +3,7 @@ import { Datacore } from "index/datacore"; | |
import { DateTime } from "luxon"; | ||
import { App, Plugin, PluginSettingTab, Setting } from "obsidian"; | ||
import { DEFAULT_SETTINGS, Settings } from "settings"; | ||
import { DatacoreQueryView as DatacoreJSView, VIEW_TYPE_DATACOREJS } from "ui/view-page"; | ||
|
||
/** Reactive data engine for your Obsidian.md vault. */ | ||
export default class DatacorePlugin extends Plugin { | ||
|
@@ -47,6 +48,21 @@ export default class DatacorePlugin extends Plugin { | |
-100 | ||
); | ||
|
||
// Views: DatacoreJS view. | ||
// @ts-ignore be quiet | ||
There was a problem hiding this comment. Choose a reason for hiding this commentThe reason will be displayed to describe this comment to others. Learn more. Why can this not be typed? |
||
this.registerView(VIEW_TYPE_DATACOREJS, (leaf) => new DatacoreJSView(leaf, this.api)); | ||
|
||
// Add a command for creating a new view page. | ||
this.addCommand({ | ||
id: "datacore-add-view-page", | ||
name: "Create View Page", | ||
callback: () => { | ||
const newLeaf = this.app.workspace.getLeaf("tab"); | ||
newLeaf.setViewState({ type: VIEW_TYPE_DATACOREJS, active: true }); | ||
this.app.workspace.setActiveLeaf(newLeaf, { focus: true }); | ||
}, | ||
}); | ||
|
||
// Register JS highlighting for codeblocks. | ||
this.register(this.registerCodeblockHighlighting()); | ||
|
||
|
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Original file line number | Diff line number | Diff line change |
---|---|---|
@@ -0,0 +1,20 @@ | ||
|
||
declare module "react-select" { | ||
import { RefAttributes, ReactElement, JSX } from "preact/compat"; | ||
import { StateManagerAdditionalProps } from "react-select/dist/declarations/src/useStateManager"; | ||
import { Props } from "react-select/dist/declarations/src/Select"; | ||
import Select from "react-select/dist/declarations/src/Select"; | ||
export * from "react-select/dist/declarations/src/types"; | ||
declare type StateManagedPropKeys = 'inputValue' | 'menuIsOpen' | 'onChange' | 'onInputChange' | 'onMenuClose' | 'onMenuOpen' | 'value'; | ||
declare type PublicBaseSelectProps<Option, IsMulti extends boolean, Group extends GroupBase<Option>> = JSX.LibraryManagedAttributes<typeof Select, Props<Option, IsMulti, Group>>; | ||
declare type SelectPropsWithOptionalStateManagedProps<Option, IsMulti extends boolean, Group extends GroupBase<Option>> = Omit<PublicBaseSelectProps<Option, IsMulti, Group>, StateManagedPropKeys> & Partial<PublicBaseSelectProps<Option, IsMulti, Group>>; | ||
export declare type StateManagerProps<Option = unknown, IsMulti extends boolean = boolean, Group extends GroupBase<Option> = GroupBase<Option>> = SelectPropsWithOptionalStateManagedProps<Option, IsMulti, Group> & StateManagerAdditionalProps<Option>; | ||
declare const StateManagedSelect: < | ||
Option = unknown, | ||
IsMulti extends boolean = false, | ||
Group extends GroupBase<Option> = GroupBase<Option> | ||
>( | ||
props: StateManagerProps<Option, IsMulti, Group> | ||
) => ReactElement; | ||
export default StateManagedSelect; | ||
} |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Original file line number | Diff line number | Diff line change |
---|---|---|
@@ -0,0 +1,24 @@ | ||
.dc-cm-editor .cm-gutters { | ||
flex: 0 0 auto; | ||
background-color: transparent; | ||
color: var(--text-faint) !important; | ||
border-right: none !important; | ||
margin-inline-end: var(--file-folding-offset); | ||
font-size: var(--font-ui-smaller); | ||
z-index: 1; | ||
font-variant: tabular-nums; | ||
} | ||
.cm-typeName { | ||
color: var(--headers); | ||
} | ||
.dc-cm-editor { | ||
padding: 1em; | ||
border-radius: 0.5em; | ||
border: 1px solid var(--h5-color); | ||
} | ||
.cm-tooltip.cm-tooltip-autocomplete { | ||
background: var(--embed-bg); | ||
} | ||
.dc-cm-editor img.cm-widgetBuffer[aria-hidden="true"] { | ||
display: none; | ||
} |
Oops, something went wrong.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I don't think I'd do it like this - it's better to expose hook functions which load this data instead (like
dc.useSettings()
).