Skip to content

fix js loading in newer versions #33

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Open
wants to merge 1 commit into
base: main
Choose a base branch
from
Open

Conversation

Robonau
Copy link

@Robonau Robonau commented Apr 4, 2025

fixes #32

i expect the issue was to do with the rename from failfast to blibla

i just replaced how you were loading js with how impact pack does

@NSFWlove
Copy link

NSFWlove commented Apr 6, 2025

fixes #32

i expect the issue was to do with the rename from failfast to blibla

i just replaced how you were loading js with how impact pack does

impact loads differently? as far as I understood it you simply re-name the folder. but I'm guessing I'm wrong because that's not working for me.

@Robonau
Copy link
Author

Robonau commented Apr 10, 2025

simply changing failfast-comfyui-extensions to blibla-comfyui-extensions with the current way of doing things didn't work for me. so i swapped out the whole setup_js function for what impact pack does (knowing that impact pack works)

note: if the folder you have is still failfast then no this will not work
but any installs since the change to blibla need it to be blibla and not failfast

i am currently running this edited branch on comfy Commit e471c72 (3 weeks ago) with no issues

@AksKun
Copy link

AksKun commented May 4, 2025

doesn't work for me. does anyone have the file ready?

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

pls update
3 participants