Bsc base #138
Merged
Bsc base #138
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
* change the default timeout * complete the change log
* fix nil point error in getBalance rpc call * add change log * modify testcase
* upgrade tendermint to v0.33.3 * fix import * fix compilation errors
fix cycle import add header convert utils move EthHeaderToBscHeader add side chain unjail add temp testnet chain id add unjail to client update ethereum dependency resolve comment remove ethereum dependency side chain addr length must be 20
* add bridge * remove ethereum dependency * refactor * delete unused code
* remove double sign proof * add Broadcast to interface
Update readme and rename function
* refactor cross chain functions * add unbind msg
EnderCrypto
previously approved these changes
Aug 18, 2020
EnderCrypto
reviewed
Aug 19, 2020
| @@ -0,0 +1,612 @@ | |||
| // Copyright 2014 The go-ethereum Authors | |||
There was a problem hiding this comment.
Shall we reference the library instead of copy the file into project?
| @@ -34,6 +37,10 @@ func (this ChainNetwork) Bech32Prefixes() string { | |||
| switch this { | |||
| case TestNetwork: | |||
| return "tbnb" | |||
| case TmpTestNetwork: | |||
There was a problem hiding this comment.
Do we still need this?
forcodedancing
approved these changes
Aug 20, 2020
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.