Add check in mta_proof #205
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
ackratos
reviewed
Sep 1, 2022
common/safe_prime.go
Outdated
| // not a prime number. In this case, add `2` and try again. Do it at most 10 | ||
| // times. If `q != 1 (mod 3)`, go to the point 4. | ||
| // 4. Now we know `q` is potentially prime and `p = 2q+1` is not a multiple of | ||
| // 3. We execute a preliminary primality test on `p`, checking whether |
There was a problem hiding this comment.
I don't think we should delete the indent here
yycen
force-pushed
the
mta_proof_edge_check
branch
from
4871684 to
5ae8ad0
Compare
This reverts commit 4871684.
ackratos
approved these changes
Sep 1, 2022
lukasz-zimnoch
pushed a commit
to keep-network/tss-lib
that referenced
this pull request
Sep 14, 2022
lukasz-zimnoch
pushed a commit
to keep-network/tss-lib
that referenced
this pull request
Sep 14, 2022
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Add some checks according to report