Adds a sans-io fsm to the read operation. #274
Merged
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
@anarthal: Notes for the code review
exec_fsm
.reader_fsm
after it resumes, which improves log information content.detail
namespace, so I make fsm actions a public type, this is needed to interpret log messages. I would like to do this to theexec_fsm
too once a log object becomes available forasync_exec
, so I did not change your code yet.Example log for the subscriber example. Once all ops are refactored to use an fsm, the log will become very detailed and more helpful