exclude symfony polyfills from php scoper during PHAR compilation #579
Conversation
|
@box-project / @humbug It looks like I need maintainer approval to run the required Github workflow, so can someone please run this and merge this contribution at their earliest convenience? This is my first time contributing to this project so I'm not completely sure what else is required of a PR in order for it to be accepted. |
|
Looks good to me! Maybe someone from @box-project or @humbug could take a look? 😃 |
|
@theofidry I see you are listed as a maintainer of this project. Can I get this reviewed and hopefully merged? (also going forward, what is the protocol to get things merged for this project?) |
|
@DAcodedBEAT sorry I cannot check in details atm. Right now there is two blocking issues for respectively PHP-Scoper (a content overall which no one can do but I) and Box (#571) which need to be dealt with. Once done I believe there is some (minor) cleanup to do and both projects can be released once again with full 8.1 support |
This commit resolves this issue around PHAR compilation: ``` PHP Fatal error: Uncaught Error: Call to undefined function _HumbugBox48cf944fc33a\Symfony\Component\Console\get_debug_type() ``` The solution used is using a similar approach to humbug/php-scoper#481 Resolves box-project#550
DAcodedBEAT
force-pushed
the
fix-phar-compilation
branch
from
7725b4a to
8876183
Compare
|
Thank you @DAcodedBEAT |
This PR resolves this issue around PHAR compilation:
The solution used is using a similar approach to humbug/php-scoper#481
Resolves #550