Skip to content

When turning off and on Brave Shields, Block Scripts and Block Fingerprinting are shown as disabled. #43968

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Closed
3 of 5 tasks
hffvld opened this issue Feb 13, 2025 · 1 comment · Fixed by brave/brave-core#27930
Assignees
Labels
bug feature/shields The overall Shields feature in Brave. OS/iOS Fixes related to iOS browser functionality priority/P3 The next thing for us to work on. It'll ride the trains. privacy QA Pass - iPhone QA/Yes release-notes/include security
Milestone

Comments

@hffvld
Copy link
Contributor

hffvld commented Feb 13, 2025

Description

When turning off and on Brave Shields, Block Scripts and Block Fingerprinting are shown as disabled if they were previously enabled.

Steps to reproduce

  1. Launch Brave
  2. Go to any website
  3. Open Brave Shields > Advanced controls > Confirm that Block Scripts and Block Fingerprinting are enabled
  4. Turn off Brave Shields
  5. Close and reopen Brave Shields
  6. Turn on Brave Shields > Observe that Block Scripts and Block Fingerprinting are shown as disabled
  7. Close and reopen Brave Shields again > Observe that Block Scripts and Block Fingerprinting are actually enabled

Actual result

When turning off and on Brave Shields, Block Scripts and Block Fingerprinting are shown as disabled if they were previously enabled.


2025-02-13_12-22-13.mp4

Expected result

When turning off and on Brave Shields, Block Scripts and Block Fingerprinting must not be shown as disabled if they were previously enabled.

Reproduces how often

Easily reproduced

Brave version

Brave build: 1.77 (39)
BraveCore: 1.77.39 (133.0.6943.98)

Device/iOS version

iPhone 14 / iOS 17.7.2

Affected browser versions

  • latest AppStore
  • latest TestFlight
  • previous TestFlight

Reproducibility

  • with Brave Shields disabled
  • in the latest version of mobile Safari

Miscellaneous information

No response

@hffvld hffvld added bug feature/shields The overall Shields feature in Brave. OS/iOS Fixes related to iOS browser functionality QA/Yes labels Feb 13, 2025
@ShivanKaul ShivanKaul added the priority/P3 The next thing for us to work on. It'll ride the trains. label Feb 25, 2025
@brave-builds brave-builds added this to the 1.78.x - Nightly milestone Mar 5, 2025
@hffvld
Copy link
Contributor Author

hffvld commented Apr 23, 2025

Verified on iPhone 14 using version(s):

Device/OS: iPhone 14 / iOS 17.7.2
Brave build: 1.78 (87)
BraveCore: 1.78.87 (135.0.7049.100)

STEPS:

  1. Follow the STR/TP from When turning off and on Brave Shields, Block Scripts and Block Fingerprinting are shown as disabled. #43968 (comment)
  2. Verify

ACTUAL RESULTS:

  • Verified that Block Scripts and Block Fingerprinting are correctly shown as enabled after disabling and enabling Shields.

1
Screencast
1

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
bug feature/shields The overall Shields feature in Brave. OS/iOS Fixes related to iOS browser functionality priority/P3 The next thing for us to work on. It'll ride the trains. privacy QA Pass - iPhone QA/Yes release-notes/include security
Projects
None yet
Development

Successfully merging a pull request may close this issue.

5 participants