Replace cloudflare export condition in pg-cloudflare with workerd
#3498
+15
−10
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
TrySound
reviewed
Jun 26, 2025
Comment on lines
+14
to
17
| "workerd": { | ||
| "import": "./esm/index.mjs", | ||
| "require": "./dist/index.js" | ||
| }, |
There was a problem hiding this comment.
I would keep both for backward compatibility
There was a problem hiding this comment.
Given that the cloudflare condition was only added very recently and seems broken for most people using it, I would be in favour of removing it. We don't want to encourage others to use this as an export condition for Cloudflare Workers.
|
aye! sorry for breaking this - trying to migrate to esm while also maintaining commonjs compat has been an absolute nightmare, surprisingly! I'll get this pushed up ASAP! ❤️ |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fixes #3493
Fixes cloudflare/workers-sdk#9668
This changes the export conditions for
pg-cloudflareto useworkerdinstead ofcloudflare.workerdis the standard export condition for Cloudflare Workers, as specified by WinterCG - https://runtime-keys.proposal.wintercg.org/#workerd. This will ensure compatibility with Wrangler and the Cloudflare Vite plugin.