-
Notifications
You must be signed in to change notification settings - Fork 602
VCF Data Sources now preserve FILTER field #5598
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
VCF Data Sources now preserve FILTER field #5598
Conversation
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Can you add a test that will produce a VCF with a funcotation annotation and that we can parse it and retrieve the FILTER field?
* The name of the additional FILTER status field to add to VCF annotations to preserve the FILTER status of the original (data source) | ||
* variant. | ||
*/ | ||
private static final String FILTER_FIELD_NAME = "FILTER"; |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Isn't there a VCFConstants constant for this?
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Not that I can see. There's one that's close, but contains comments which won't work:
public static final String FILTER_HEADER_START = "##FILTER";
Codecov Report
@@ Coverage Diff @@
## master #5598 +/- ##
===============================================
+ Coverage 87.047% 87.048% +0.001%
- Complexity 31525 31528 +3
===============================================
Files 1928 1928
Lines 145343 145377 +34
Branches 16090 16091 +1
===============================================
+ Hits 126517 126548 +31
- Misses 12966 12967 +1
- Partials 5860 5862 +2
|
99a20d5
to
f9fba5b
Compare
@LeeTL1220 Added in a specific integration test for the Also rebased on master to fix the unrelated R test failures. |
No description provided.