Skip to content

Added liftover wdls and jsons for gnomAD 2.1 #5604

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 1 commit into from
Jan 25, 2019

Conversation

jonn-smith
Copy link
Collaborator

@jonn-smith jonn-smith commented Jan 24, 2019

Added WDLs to subset the INFO field annotations to only the allele frequency fields.

Also modified the mutect2 wdl to produce a gnomAD with only AF fields.

@davidbenjamin - you may want to double-check my updates to the M2 support wdl.

Minor changes to test script.
@codecov-io
Copy link

codecov-io commented Jan 24, 2019

Codecov Report

Merging #5604 into master will increase coverage by 0.004%.
The diff coverage is n/a.

@@               Coverage Diff               @@
##              master     #5604       +/-   ##
===============================================
+ Coverage     87.035%   87.039%   +0.004%     
- Complexity     31535     31537        +2     
===============================================
  Files           1930      1930               
  Lines         145443    145443               
  Branches       16090     16090               
===============================================
+ Hits          126586    126592        +6     
+ Misses         12997     12992        -5     
+ Partials        5860      5859        -1
Impacted Files Coverage Δ Complexity Δ
...e/hellbender/engine/spark/SparkContextFactory.java 71.233% <0%> (-2.74%) 11% <0%> (ø)
...nder/utils/runtime/StreamingProcessController.java 67.773% <0%> (+0.474%) 33% <0%> (ø) ⬇️
...ithwaterman/SmithWatermanIntelAlignerUnitTest.java 90% <0%> (+30%) 2% <0%> (ø) ⬇️
...utils/smithwaterman/SmithWatermanIntelAligner.java 90% <0%> (+40%) 3% <0%> (+2%) ⬆️

Copy link
Contributor

@LeeTL1220 LeeTL1220 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@jonn-smith Minor point. Feel free to merge once addressed.

@@ -2,7 +2,7 @@
"LiftoverVcf.gatk_docker": "broadinstitute/gatk:4.0.11.0",

Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

IS this something that general users would use? If not, maybe this should go into an unsupported directory? Especially, since I see some gs://broad-dsde-methods-jonn urls...

Copy link
Collaborator Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Typically no.

As I mentioned in previous PRs, I have placed a file indicating that the data source scripts are unsupported in the data source scripts folder.

@@ -0,0 +1,151 @@
# Removes a given list of INFO field annotations from the given VCF files.
#
# Description of inputs:
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks for doing this!

Copy link
Collaborator Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

No prob.

@jonn-smith jonn-smith merged commit e4c90aa into master Jan 25, 2019
@jonn-smith jonn-smith deleted the jts_m2_gnomad_abridged branch January 25, 2019 19:44
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants