-
Notifications
You must be signed in to change notification settings - Fork 602
Added liftover wdls and jsons for gnomAD 2.1 #5604
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Conversation
Minor changes to test script.
Codecov Report
@@ Coverage Diff @@
## master #5604 +/- ##
===============================================
+ Coverage 87.035% 87.039% +0.004%
- Complexity 31535 31537 +2
===============================================
Files 1930 1930
Lines 145443 145443
Branches 16090 16090
===============================================
+ Hits 126586 126592 +6
+ Misses 12997 12992 -5
+ Partials 5860 5859 -1
|
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
@jonn-smith Minor point. Feel free to merge once addressed.
@@ -2,7 +2,7 @@ | |||
"LiftoverVcf.gatk_docker": "broadinstitute/gatk:4.0.11.0", | |||
|
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
IS this something that general users would use? If not, maybe this should go into an unsupported directory? Especially, since I see some gs://broad-dsde-methods-jonn urls...
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Typically no.
As I mentioned in previous PRs, I have placed a file indicating that the data source scripts are unsupported in the data source scripts folder.
@@ -0,0 +1,151 @@ | |||
# Removes a given list of INFO field annotations from the given VCF files. | |||
# | |||
# Description of inputs: |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Thanks for doing this!
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
No prob.
Added WDLs to subset the INFO field annotations to only the allele frequency fields.
Also modified the
mutect2
wdl to produce a gnomAD with only AF fields.@davidbenjamin - you may want to double-check my updates to the M2 support wdl.