-
Notifications
You must be signed in to change notification settings - Fork 602
Change default blocking and NON-REF LOD params for M2 GVCF mode #5615
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Conversation
@droazen I'd like this to squeeze into 4.1. Tests pass locally after the second commit. |
Codecov Report
@@ Coverage Diff @@
## master #5615 +/- ##
===============================================
- Coverage 87.037% 86.886% -0.151%
- Complexity 31537 31614 +77
===============================================
Files 1930 1933 +3
Lines 145455 145939 +484
Branches 16090 16178 +88
===============================================
+ Hits 126600 126801 +201
- Misses 12996 13255 +259
- Partials 5859 5883 +24
|
@davidbenjamin please review |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
You can take or leave the comment about avoiding the initialization block. 👍
@@ -251,12 +251,12 @@ public double getInitialLod() { | |||
"(must be specified in increasing order)", optional = true) | |||
public List<Double> GVCFGQBands = new ArrayList<>(70); | |||
{ | |||
for (double i = -4.0; i <= 1; i = i + 0.5) { | |||
for (double i = -2.5; i <= 1; i = i + 0.5) { |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Could you use GVCFGQBands = Arrays.asList(MathUtils.createEvenlySpacedPoints(-2.5, 1, 8))
?
I'm going to keep the initialization as is because it mirrors HaplotypeCaller and because I feel like defining blocks by their size is more intuitive than defining the number of blocks between two bounds. |
Teeny tiny PR -- not happy with the AF thresholding for GVCF mode yet