Changed cr.igv.seg output of ModelSegments to give log2 Segment_Mean. #5976
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Also changed LegacySegmentCollection and CalledLegacySegmentCollection writers to overwrite instead of append. (This was fixed for AbstractRecordCollection writers in an earlier PR but was missed in these collections that override the default writer.)
See https://gatkforums.broadinstitute.org/gatk/discussion/24048/a-few-things-need-help-about-output-of-command-modelsegments#latest for some context. In principle, IGV should be able to handle linear scaling, but it scales automatically for seg files and I'm not sure if you can get around it without some additional steps. Seems easier to just output log2 copy ratios. (Perhaps we initially output linear copy ratios to maintain backwards compatibility with previous versions of GATK CNV? If so, the *LegacySegmentCollections seem to be pulling double duty, since we use them to provide IGV compatibility. In any case, we are currently inconsistent between ModelSegments and CallCopyRatioSegments, as I noted in the forum post.)
@LeeTL1220 any objections? If downstream scripts are consuming the IGV output of ModelSegments, they should be adjusted if necessary.