Refactoring / housekeeping Mutect2IntegrationTest #6184
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
cmnbroad
reviewed
Sep 25, 2019
| runFilterMutectCalls(unfilteredVcf, filteredVcf, b37Reference, | ||
| args -> args.addFileArgument(M2FiltersArgumentCollection.TUMOR_SEGMENTATION_LONG_NAME, segments), | ||
| args -> args.addFileArgument(M2FiltersArgumentCollection.CONTAMINATION_TABLE_LONG_NAME, contamination), | ||
| args -> args.addFileArgument(FilterMutectCalls.FILTERING_STATS_LONG_NAME, stats)); |
There was a problem hiding this comment.
@davidbenjamin Totally random request: while you're in here, can you change this test so it doesn't write to the checked-in version of this file (running the test always leaves the working directory in a modified state).
There was a problem hiding this comment.
@cmnbroad Hmm, I bet that file shouldn't be checked in at all. Let me fix that.
takutosato
approved these changes
Sep 25, 2019
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
@takutosato Can you review this devastatingly boring PR? Please don't waste much time on it.