Actually output the corrected bases in the ReadErrorCorrector #6366
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
droazen
suggested changes
Jan 9, 2020
| correctedRead.setBaseQualities(inputRead.getBaseQualities()); | ||
| correctedRead.setBases(inputRead.getBases()); | ||
| correctedRead.setBaseQualities(correctedQuals); | ||
| correctedRead.setBases(correctedBases); |
There was a problem hiding this comment.
Can you add a test that fails before this change, and passes after it?
|
Looks good! |
|
@davidbenjamin How do you feel about merging this quick fix as-is while we're waiting for the next-gen error corrector to be merged? |
|
@droazen I think we should definitely merge the quick fix. |
droazen
approved these changes
Jan 21, 2020
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
See #6365