Skip to content

fix an NPE in FastaReferenceMaker #6435

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
merged 1 commit into from
Feb 3, 2020
Merged

fix an NPE in FastaReferenceMaker #6435

merged 1 commit into from
Feb 3, 2020

Conversation

lbergelson
Copy link
Member

@lbergelson
fix an NPE in FastaReferenceMaker
31b0133 
* We now check if the writer is null before trying to close it.
@lbergelson lbergelson mentioned this pull request Feb 3, 2020
Closed
2 tasks
@gatk-bot
Copy link

gatk-bot commented Feb 3, 2020

Travis reported job failures from build 28943
Failures in the following jobs:

Test Type JDK Job ID Logs
cloud openjdk8 28943.1 logs

davidbenjamin
davidbenjamin approved these changes Feb 3, 2020
View reviewed changes
Copy link
Contributor

@davidbenjamin davidbenjamin left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This looks good. Was the NPE in closeTool masking an upstream error?

@lbergelson
Copy link
Member Author

I think it must be, but I don't know what the upstream error is until the user tries with the fix. I suspect something along the lines of "file not found"

@davidbenjamin
Copy link
Contributor

Well, I'm satisfied regardless.

@lbergelson lbergelson merged commit a78bf17 into master Feb 3, 2020
@lbergelson lbergelson deleted the lb_npe_in_fastareference branch February 3, 2020 19:23
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@davidbenjamin davidbenjamin davidbenjamin approved these changes

Assignees

@davidbenjamin davidbenjamin

Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@lbergelson @gatk-bot @davidbenjamin