Skip to content

Clean up deprecated fields from stagehand.ts and allow CDP parameterization #609

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 11 commits into from
Mar 29, 2025

Conversation

kamath
Copy link
Contributor

@kamath kamath commented Mar 27, 2025

why

Allowing CDP URL parameterization and removing deprecated fields

what changed

  • Removed previously deprecated fields from Stagehand constructor
  • Added cdpUrl to localBrowserLaunchOptions
  • Added deterministic evals for cdpUrl and resumeSession
  • Changed resume session logic to pull connect URL from BB API

test plan

evals + added resume session evals

Copy link

changeset-bot bot commented Mar 27, 2025

🦋 Changeset detected

Latest commit: 75ad136

The changes in this PR will be included in the next version bump.

This PR includes changesets to release 1 package
Name Type
@browserbasehq/stagehand Minor

Not sure what this means? Click here to learn what changesets are.

Click here if you're a maintainer who wants to add another changeset to this PR

@kamath kamath changed the title Anirudh/add custom cdp Clean up deprecated fields from stagehand.ts and allow CDP parameterization Mar 27, 2025
@kamath kamath marked this pull request as ready for review March 27, 2025 05:49
@kamath kamath marked this pull request as draft March 27, 2025 05:49
@kamath kamath marked this pull request as ready for review March 27, 2025 06:32
@seanmcguire12 seanmcguire12 added the act These changes pertain to the act function label Mar 27, 2025
@seanmcguire12 seanmcguire12 self-requested a review March 29, 2025 18:39
@kamath kamath merged commit c92295d into main Mar 29, 2025
15 checks passed
@github-actions github-actions bot mentioned this pull request Mar 29, 2025
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
act These changes pertain to the act function
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants