Skip to content

Trim excess threads onSend #2148

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 3 commits into from
Feb 27, 2025
Merged

Conversation

YYChen01988
Copy link
Contributor

@YYChen01988 YYChen01988 commented Feb 17, 2025

Goal

Trim event threads if the size is too large

Design

Threads are now be trimmed less equal config maxReportedThreads in EventPayload

Testing

Introduced a new unit test to cover EventPayload.trimToSize

@YYChen01988 YYChen01988 requested a review from lemnik as a code owner February 17, 2025 15:30
@bugsnagbot
Copy link
Collaborator

bugsnagbot commented Feb 17, 2025

Android notifier sizes

Format Size impact of Bugsnag (kB) Size impact of Bugsnag when Minified (kB)
APK 1875.95 1679.13
arm64_v8a 651.52 450.82
armeabi_v7a 585.99 385.29
x86 725.23 528.62
x86_64 696.57 495.86

Generated by 🚫 Danger

@lemnik lemnik changed the title trim threads size Trim excess threads onSend Feb 18, 2025
@YYChen01988 YYChen01988 force-pushed the PLAT-13360/trim-ExitInfo-payload-size branch from 5e6a607 to 2d05bc2 Compare February 18, 2025 13:21
@lemnik lemnik requested a review from tomlongridge February 26, 2025 12:03
lemnik
lemnik previously approved these changes Feb 26, 2025
@lemnik lemnik force-pushed the PLAT-13360/trim-ExitInfo-payload-size branch from 684e5cc to 4193a4e Compare February 26, 2025 13:39
@YYChen01988 YYChen01988 merged commit 3a3c7ba into next Feb 27, 2025
35 checks passed
@YYChen01988 YYChen01988 deleted the PLAT-13360/trim-ExitInfo-payload-size branch February 27, 2025 10:27
@YYChen01988 YYChen01988 mentioned this pull request Mar 3, 2025
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants