Fix crash-time date calculation #2158
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Android notifier sizes
Generated by 🚫 Danger |
lemnik
force-pushed
the
PLAT-13769/off-by-one-error-device-date
branch
from
f25292b to
9ecbdb9
Compare
tomlongridge
previously approved these changes
Feb 27, 2025
lemnik
force-pushed
the
PLAT-13769/off-by-one-error-device-date
branch
from
9076e96 to
7b95973
Compare
tomlongridge
approved these changes
Feb 27, 2025
Merged
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Goal
Fix an error in the day/date calculation that runs as part of the NDK crash reporting and is used to format the device time.
Testing
Manually tested & introduced new unit tests to cover the edge cases (including a full 20years of formatting in 6 hour increments - ignored for CI).