-
Notifications
You must be signed in to change notification settings - Fork 208
Migrate version information to device.runtimeVersions #472
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Conversation
sdk/src/androidTest/java/com/bugsnag/android/DeviceDataSummaryTest.java
Outdated
Show resolved
Hide resolved
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Thanks for the review, I've responded to the comments and updated the PR. Moving the |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Tests look good and run fine
Dismissing to avoid review confusion as per slack conversation
I have updated the PR so that As part of these changes I created |
Goal
We should collect the API level in
device.runtimeVersions.apiLevel
anddevice.runtimeVersions.osBuild
for all error reports and sessions.Changeset
device.apiLevel
todevice.runtimeVersions.androidApiLevel
device.osBuild
todevice.runtimeVersions.osBuild
Tests
Ran existing tests and created new mazerunner scenarios, which verify that a JVM error/session and NDK fatal error include
device.runtimeVersions.androidApiLevel
.