Skip to content

Migrate version information to device.runtimeVersions #472

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 9 commits into from
Apr 25, 2019

Conversation

fractalwrench
Copy link
Contributor

@fractalwrench fractalwrench commented Apr 17, 2019

Goal

We should collect the API level in device.runtimeVersions.apiLevel and device.runtimeVersions.osBuild for all error reports and sessions.

Changeset

  • Moved device.apiLevel to device.runtimeVersions.androidApiLevel
  • Moved device.osBuild to device.runtimeVersions.osBuild
  • Updated NDK JNI calls to retrieve api level and osBuild from new location

Tests

Ran existing tests and created new mazerunner scenarios, which verify that a JVM error/session and NDK fatal error include device.runtimeVersions.androidApiLevel.

Copy link
Contributor

@bengourley bengourley left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

A few comments to address or respond to, otherwise looks like it's working well.

What about osBuild property which looks like it gets migrated to the runtimeVersions map? Should that be moved over on the notifier side too?

image

@fractalwrench
Copy link
Contributor Author

Thanks for the review, I've responded to the comments and updated the PR.

Moving the osBuild is not in the product or engineering design so no change has been made - @duncanhewett is this ok?

Cawllec
Cawllec previously approved these changes Apr 24, 2019
Copy link
Contributor

@Cawllec Cawllec left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Tests look good and run fine

@fractalwrench fractalwrench dismissed Cawllec’s stale review April 24, 2019 10:37

Dismissing to avoid review confusion as per slack conversation

@fractalwrench
Copy link
Contributor Author

I have updated the PR so that device.osBuild is now serialised in device.runtimeVersions.osBuild instead.

As part of these changes I created bsg_get_map_value_obj to reduce duplication in retrieving an object from a Map, via the JNI. I've also refactored the existing bsg_get_map_value_* functions to use this, which has cut down on repetition.

@fractalwrench fractalwrench merged commit 6743f99 into next Apr 25, 2019
@fractalwrench fractalwrench deleted the runtime-versions branch April 25, 2019 09:02
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants