Skip to content

fix: Add helper for syncing a unity session to native reports #333

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 2 commits into from
Mar 14, 2019

Conversation

kattrali
Copy link
Contributor

Goal

Allow registering a session with the SessionTracker to be propagated to crash reports. This allows the session to be tracked separately via bugsnag-unity while preserving the stability score. The change is internally facing only.

Related to bugsnag/bugsnag-unity#138

Tests

Tested manually as a part of bugsnag/bugsnag-unity#138

Review

Outstanding Questions

  • This pull request is ready for:
    • Initial review of the intended approach, not yet feature complete
    • Structural review of the classes, functions, and properties modified
    • Final review

@fractalwrench
Copy link
Contributor

This will need a changelog entry when the changes are complete.

@kattrali
Copy link
Contributor Author

@fractalwrench Will it? Its entirely internally facing and documented in bugsnag/bugsnag-unity#138.

@fractalwrench
Copy link
Contributor

@kattrali this PR alters source code so we should document the change, even though it isn't anticipated to affect Cocoa users. At least, that's my interpretation of the documented Platform Change Process.

@kattrali kattrali merged commit b1a5ef9 into master Mar 14, 2019
@kattrali kattrali deleted the kattrali/unity-sync-all branch March 14, 2019 12:29
@kattrali kattrali restored the kattrali/unity-sync-all branch March 14, 2019 13:01
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants