Convert @bugsnag/core/lib/iserror to TypeScript #2422
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
AnastasiiaSvietlova
changed the title
gingerbenw
reviewed
Apr 23, 2025
| @@ -1 +0,0 @@ | |||
| module.exports = require('iserror') | |||
There was a problem hiding this comment.
now that we've replicated this code in TS, we can remove the dependency on this library from packages/core/package.json
| @@ -1,5 +1,4 @@ | |||
| import { Config, Plugin } from '@bugsnag/core' | |||
| import isError from '@bugsnag/core/lib/iserror' | |||
| import { isError, Config, Plugin } from '@bugsnag/core' | |||
There was a problem hiding this comment.
Suggested change
| import { isError, Config, Plugin } from '@bugsnag/core' | |
| import { isError } from '@bugsnag/core' | |
| import type { Config, Plugin } from '@bugsnag/core' |
gingerbenw
approved these changes
Apr 29, 2025
Comment on lines
+1
to
+2
| import { isError } from '@bugsnag/core' | ||
| import type { Config, Plugin } from '@bugsnag/core' |
There was a problem hiding this comment.
👌🏻 good separation of types and functionality here
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Goal
Convert @bugsnag/core/lib/iserror to TypeScript
Testing
Covered by existing end to end and unit tests