Convert @bugsnag/core/src/lib/feature-flag-delegate to TypeScript #2459
+123
−106
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
| } | ||
| return result; | ||
| }); | ||
| }, |
There was a problem hiding this comment.
toEventApi method was rewrite with assistance of Copilot.
gingerbenw
force-pushed
the
PLAT-13690-feature-flag-delegate
branch
from
fd583de to
911e9c3
Compare
gingerbenw
force-pushed
the
PLAT-13690-feature-flag-delegate
branch
from
911e9c3 to
d6acfbc
Compare
gingerbenw
reviewed
Jun 24, 2025
Comment on lines
11
to
18
| add: (existingFeatures: Array<FeatureFlag | null>, existingFeatureKeys: { [key: string]: unknown }, name?: unknown, variant?: any ) => void | ||
| merge: ( | ||
| existingFeatures: Array<{ name: string; variant?: any } | null>, | ||
| newFeatures: any, | ||
| existingFeatureKeys: { [key: string]: any } | ||
| ) => Array<{ name: string; variant: any }> | undefined | ||
| toEventApi: (featureFlags: Array<FeatureFlag | null>) => FeatureFlagEventApi[] | ||
| clear: (features: any, featuresIndex: any, name: any) => void |
There was a problem hiding this comment.
there's a lot of any going on here - is it possible to figure out some more of these types? i.e. the third parameter of clear, name is probably a string?
| return (featureFlags || []) | ||
| .filter((flag): flag is FeatureFlag => flag !== null && typeof flag === 'object') | ||
| .map((flag) => { | ||
| const result: { featureFlag: string; variant?: string } = { featureFlag: flag.name }; |
There was a problem hiding this comment.
Suggested change
| const result: { featureFlag: string; variant?: string } = { featureFlag: flag.name }; | |
| const result: FeatureFlagEventApi = { featureFlag: flag.name }; |
AnastasiiaSvietlova
force-pushed
the
PLAT-13690-feature-flag-delegate
branch
from
56aacd2 to
c0bbe17
Compare
gingerbenw
approved these changes
Jun 26, 2025
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Goal
Convert @bugsnag/core/src/lib/feature-flag-delegate to TypeScript
Testing
Covered by existing end to end and unit tests