Remove @bugsnag/core/lib/es-utils/includes #2465
Open
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
| import { add, clear, merge } from './lib/feature-flag-delegate' | ||
| import { BreadcrumbType, Config, Delivery, FeatureFlag, LoggerConfig, NotifiableError, Notifier, OnBreadcrumbCallback, OnErrorCallback, OnSessionCallback, Plugin, SessionDelegate, User } from './common' | ||
| import { BreadcrumbType, BREADCRUMB_TYPES, Config, Delivery, FeatureFlag, LoggerConfig, NotifiableError, Notifier, OnBreadcrumbCallback, OnErrorCallback, OnSessionCallback, Plugin, SessionDelegate, User } from './common' |
There was a problem hiding this comment.
Not sure why it was doubled. But I replace BREADCRUMB_TYPES from lib/breadcrumb-types with ones from common. They are identical.
| const types = this._config.enabledBreadcrumbTypes | ||
|
|
||
| return types === null || includes(types, type) | ||
| return types === null || types.includes(type) |
There was a problem hiding this comment.
Here is a little complication. As we were having type as string TS complaining that in line 327: TS2345: Argument of type string is not assignable to parameter of type BreadcrumbType. Because const types: BreadcrumbType[].
And if I will change it to BreadcrumbType, I'm having an issue in plugin-browser-session/src/session.
_isBreadcrumbTypeEnabled: (type: ConsoleMethod) => boolean
So currently I set (type: any).
gingerbenw
force-pushed
the
PLAT-13688-includes
branch
from
08f2229 to
e13793d
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Goal
Remove @bugsnag/core/lib/es-utils/includes and replace it with Array.prototype.includes().
Design
Publish core as ES module with TypeScript
Changeset
Delete @bugsnag/core/lib/es-utils/includes
Delete
breadcrumb-types.tsas we already have that types incommon.tsTesting
Covered by existing end to end and unit tests