Fix Android ReleaseStage not being set #124
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…re correctly overridden using 'virtual' and 'override' keywords
Cawllec
commented
Jan 31, 2019
| public AbstractConfiguration(string apiKey) | ||
| public AbstractConfiguration() {} | ||
|
|
||
| protected virtual void SetupDefaults(string apiKey) |
There was a problem hiding this comment.
If all the default values that would be overridden are set here, they won't need to be set in the other configurations.
kattrali
approved these changes
Jan 31, 2019
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Goal
Fixes an issue where the ReleaseStage wasn't being passed into the Android notifier, causing the incorrect stage to be notified.
Tests
Should be manually verified on: