fix: Use fallback stacktrace for events which have no stacktrace #131
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Capture and use a stacktrace from the notify() handle if an event is reported without a stacktrace (such as logging a string or other non- Exception object).
kattrali
force-pushed
the
kattrali/use-fallback-stacktrace
branch
from
441e109 to
6422e73
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Capture and use a stacktrace from the notify() handle if an event is
reported without a stacktrace (such as logging a string or other non-
Exception object).
Tests
Manually verified the behavior by logging messages, i.e.
Debug.LogError("foo")Review
For the pull request reviewer(s), this changeset has been reviewed for: