fix: Synchronize C# metadata changes with native layer #157
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Goal
When using
Bugsnag.Metadata.Add()
, any added metadata should be synchronized with the native layer to ensure the values are sent with native crash reports as well as Unity log reports.Example usage:
Changeset
INativeClient
ref to theMetadata
initializerMetadata
class with customAdd()
andRemove()
implementations which propagate changes to the native layerReport.Metadata
class toDictionary<string, object>
instead ofMetadata
since it requires no synchronizationRequires bugsnag/bugsnag-android#505
Artifacts
Tests
Test handled and unhandled, native and C# crashes on each: