Skip to content

Add overloaded init method with autoNotify param #164

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
merged 5 commits into from
Sep 6, 2019
Merged

Add overloaded init method with autoNotify param #164

merged 5 commits into from
Sep 6, 2019

Conversation

fractalwrench
Copy link
Contributor

Goal

Allows disabling of autoNotify functionality on Android + iOS.

kattrali
kattrali previously requested changes Sep 6, 2019
View reviewed changes
Copy link
Contributor

@kattrali kattrali left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Its close! I added a few needed adjustments below.

@fractalwrench
Copy link
Contributor Author

Thanks for the catch, I've updated to set the C# property as well.

@fractalwrench fractalwrench marked this pull request as ready for review September 6, 2019 10:44
@kattrali kattrali dismissed their stale review September 6, 2019 15:18

resolved

@kattrali kattrali merged commit da1fa3a into master Sep 6, 2019
@kattrali kattrali deleted the propagate-auto-notify branch September 6, 2019 17:47
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@kattrali kattrali kattrali left review comments

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@fractalwrench @kattrali