PLAT-5159 Unity TimingTrackerObject destroys on load #239
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
rich-bugsnag
changed the base branch from
next
to
integration/unity-native-notifier-uplifts
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Goal
The session tracking object was not persisting across scenes
Design
Adding DontDestroyOnLoad is the cleanest way to make sure it stays around.
I would have added a singleton pattern to make sure it was the only one created, but i checked and the init process that creates it already has a check to make sure init only runs once.
Changeset
Added DontDestroyOnLoad to the awake method of the TimingTrackerObject behaviour
Testing
This was tested manually in the unity editor