task(config): new configuration option RedactedKeys #367
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
rich-bugsnag
changed the title
nickdowell
reviewed
Aug 17, 2021
src/BugsnagUnity/Client.cs
Outdated
| @@ -353,6 +355,36 @@ void Notify(Exception[] exceptions, HandledState handledState, Middleware callba | |||
| } | |||
| } | |||
|
|
|||
| private void CheckMetadaForRedactedKeys(Metadata metadata) | |||
There was a problem hiding this comment.
The name CheckMetadaForRedactedKeys doesn't make it clear that this function will actually redact the metadata. Maybe RedactMetadata would be a clearer?
There was a problem hiding this comment.
agreed, thanks 👍
nickdowell
approved these changes
Aug 17, 2021
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Goal
Setup metadata key redaction for the fallback/Windows and send the value through to iOS and Android
Changeset
Testing
Manually and added CI tests