Skip to content

task(config): new configuration option PersistUser #372

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 3 commits into from
Aug 19, 2021

Conversation

rich-bugsnag
Copy link
Contributor

Goal

New configuration option PersistUser to set the fallback, native Cocoa and android values

Changeset

  • Added to the config class and interface
  • Pass the value through to Cocoa and Android

Testing

Manually tested, full CI tests will be added when unity persistance layer is added

@rich-bugsnag rich-bugsnag marked this pull request as ready for review August 18, 2021 12:17
@rich-bugsnag rich-bugsnag self-assigned this Aug 18, 2021
internal static extern void bugsnag_setAutoNotifyConfig(IntPtr configuration, bool autoNotify);
internal static extern void bugsnag_setAutoNotifyConfig(IntPtr configuration, bool autoNotify);
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Can't see what's changed here 😅

@rich-bugsnag rich-bugsnag merged commit 9fa37e3 into next Aug 19, 2021
@rich-bugsnag rich-bugsnag deleted the 6687-PersistUser branch August 19, 2021 09:02
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants