Use preset log error class when message does not match pattern #45
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
In the case that a log message can't be broken into "class: message" format, use the entire log as the message and set an error class based on the severity of the log. This change pre-supposes that we make a backend change to how messages are grouped, taking error title + top line of stacktrace into account when grouping for unity.
fractalwrench
approved these changes
Jul 20, 2017
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
In the case that a log message can't be broken into "class: message" format, use the entire log as the message and set an error class based on the severity of the log. For example the following log message:
Will generate an error report with an error class of
UnityLogErrorand the messageMetalDetector detected metals.