PLAT-9092 missing stacktraces in android notify events #700
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
tomlongridge
approved these changes
Mar 3, 2023
| @@ -4,6 +4,7 @@ | |||
| using System.Collections; | |||
| using System.IO; | |||
| using System.Runtime.InteropServices; | |||
| using BugsnagUnity; | |||
There was a problem hiding this comment.
nit: unused import now
Merged
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Goal
If a C# exception is not thrown then it contains no stacktrace.
When Bugsnag.Notify(System.Exception) is called with an unthrown exception, we generate a backup stacktrace using
System.Diagnostics.StackTrace().GetFrames();Previously, when generating this trace we stripped the top 3 frames so that internal frames from the notifier would not be reported.
The pipeline now automatically marks any frame from our notifier as out of project, and in some cases we were stripping frames that should not be stripped due to compiler optimisations.
In this PR we remove the stripping and allow the pipeline to decide what is and isn't in project.
Changes to grouping
I was initially concerned that this change would break grouping for existing events but i have tested and this change will only break grouping for events where there are no InProject frames and Notify is called with an unthrown exception which is acceptable.
Changeset
Testing