Skip to content

chore(package.json): add packageManager [email protected], remove engines #202

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Conversation

sukvvon
Copy link
Contributor

@sukvvon sukvvon commented Oct 17, 2024

What:

Why:

  • the engines key means forcing a specific version. currently, we are only forcing pnpm, which means that versions of npm, yarn, node, etc., are not enforced. we do not want to enforce a version and only want a development environment, so I think it’s correct to remove the engines field and add packageManager instead

How:

  • removing the engines field provides flexibility for users to choose their package manager while using the packageManager field ensures a consistent development environment for developers.

Checklist:

  • Documentation
  • Tests
  • Ready to be merged

@bvaughn
Copy link
Owner

bvaughn commented Oct 17, 2024

I want to enforce pnpm version because I sometimes forget which version a particular project of mine is using and it has caused my trouble. Thanks though

@bvaughn bvaughn closed this Oct 17, 2024
@sukvvon sukvvon deleted the chore/remove-engines-add-packageManager branch October 20, 2024 14:31
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants