Skip to content

fix: to_bitmask return uint32_t to avoid sign extend int to uint64 #83

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 2 commits into from
Nov 23, 2023

Conversation

xiegx94
Copy link
Collaborator

@xiegx94 xiegx94 commented Nov 23, 2023

There is a bug in SkipString that caused by cast int to uint64.

@codecov-commenter
Copy link

codecov-commenter commented Nov 23, 2023

Codecov Report

All modified and coverable lines are covered by tests ✅

Comparison is base (6fabefe) 95.77% compared to head (9ba094f) 95.77%.

❗ Your organization needs to install the Codecov GitHub app to enable full functionality.

Additional details and impacted files
@@           Coverage Diff           @@
##           master      #83   +/-   ##
=======================================
  Coverage   95.77%   95.77%           
=======================================
  Files          21       21           
  Lines        2435     2435           
=======================================
  Hits         2332     2332           
  Misses        103      103           

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

@qshanz373
Copy link
Collaborator

int _mm_movemask_epi8(__m128i a)

Shall we do the zext at the place that we call it, instead of changing the return type ?

@xiegx94
Copy link
Collaborator Author

xiegx94 commented Nov 23, 2023

int _mm_movemask_epi8(__m128i a)

Shall we do the zext at the place that we call it, instead of changing the return type ?

Sonic has some to_bitmask functions and all of them should return same sign or unsign type.

Copy link
Collaborator

@qshanz373 qshanz373 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM now

@xiegx94 xiegx94 merged commit 2395791 into bytedance:master Nov 23, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants