Skip to content

[domain-deletion]Add delete domain operation in replicator #201

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 2 commits into from
May 13, 2025

Conversation

gazi-yestemirova
Copy link
Contributor

Summary

[Brief summary of the change, including the rationale and intended effect]
This PR adds a new data type to the replicator: DOMAIN_OPERATION_DELETE. This will allow us to delete global domains in a passive cluster.

Type of Change

  • Add new API(s)
  • Add new data type(s)
  • Add new field(s) to existing data type
  • Remove field(s) from data type
  • Remove data type(s)
  • Remove API(s)
  • Other (please provide detailed description)

Data Effect

  • Does it change the data stored in database? No

Detailed Description

[In-depth description of the changes made to the IDL, specifying new fields, removed fields, or modified data structures]
DOMAIN_OPERATION_DELETE data type was added to the replicator. The existing data types are:

DOMAIN_OPERATION_CREATE - used to sync domain creation
DOMAIN_OPERATION_UPDATE - replicates any domain updates in the passive cluster

Impact Analysis

  • Backward Compatibility: [Analysis of backward compatibility] Yes, as it is a new data type
  • Forward Compatibility: [Analysis of forward compatibility] Yes, as it is a new data type

Testing Plan

  • Unit Tests: [Do we have unit test covering the change?] -
  • Persistence Tests: [If the change is related to a data type which is persisted, do we have persistence tests covering the change?] -
  • Integration Tests: [Do we have integration test covering the change?] -
  • Compatibility Tests: [Have we done tests to test the backward and forward compatibility?] -

Rollout Plan

  • What is the rollout plan? Rollout to the dev environments first, then deploy to production envs in waves
  • Does the order of deployment matter? No
  • Is it safe to rollback? Does the order of rollback matter? Yes
  • Is there a kill switch to mitigate the impact immediately? No

@gazi-yestemirova gazi-yestemirova merged commit 97f83ae into master May 13, 2025
3 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants