Add tasklisttype flag to ListTaskListPartitions (#6711)

* add task list type flag to ListTaskListPartitions

* change usage help comment

Author: arzonus

tools/cli/task_list.go

@@ -53,6 +53,12 @@ func newTaskListCommands() []*cli.Command {
 					Aliases: []string{"tl"},
 					Usage:   "TaskList description",
 				},
+				&cli.StringFlag{
+					Name:    FlagTaskListType,
+					Aliases: []string{"tlt"},
+					Value:   "decision",
+					Usage:   "Optional TaskList type [decision|activity]",
+				},
 			},
 			Action: ListTaskListPartitions,
 		},

tools/cli/task_list_commands.go

@@ -99,6 +99,8 @@ func ListTaskListPartitions(c *cli.Context) error {
 	if err != nil {
 		return commoncli.Problem("Required flag not found: ", err)
 	}
+	taskListType := strToTaskListType(c.String(FlagTaskListType)) // default type is decision
+
 	ctx, cancel, err := newContext(c)
 	defer cancel()
 	if err != nil {
@@ -113,13 +115,16 @@ func ListTaskListPartitions(c *cli.Context) error {
 	if err != nil {
 		return commoncli.Problem("Operation ListTaskListPartitions failed.", err)
 	}
-	if len(response.DecisionTaskListPartitions) > 0 {
-		return printTaskListPartitions("Decision", response.DecisionTaskListPartitions)
-	}
-	if len(response.ActivityTaskListPartitions) > 0 {
-		return printTaskListPartitions("Activity", response.ActivityTaskListPartitions)
+
+	switch taskListType {
+	case types.TaskListTypeActivity:
+		return printTaskListPartitions(types.TaskListTypeActivity, response.ActivityTaskListPartitions)
+	case types.TaskListTypeDecision:
+		return printTaskListPartitions(types.TaskListTypeDecision, response.DecisionTaskListPartitions)
+	default:
+		// should never happen
+		return nil
 	}
-	return nil
 }
 
 func printTaskListPollers(w io.Writer, pollers []*types.PollerInfo, taskListType types.TaskListType) error {
@@ -136,7 +141,7 @@ func printTaskListPollers(w io.Writer, pollers []*types.PollerInfo, taskListType
 	}})
 }
 
-func printTaskListPartitions(taskListType string, partitions []*types.TaskListPartitionMetadata) error {
+func printTaskListPartitions(taskListType types.TaskListType, partitions []*types.TaskListPartitionMetadata) error {
 	table := []TaskListPartitionRow{}
 	for _, partition := range partitions {
 		table = append(table, TaskListPartitionRow{
@@ -146,7 +151,7 @@ func printTaskListPartitions(taskListType string, partitions []*types.TaskListPa
 		})
 	}
 	return RenderTable(os.Stdout, table, RenderOptions{Color: true, OptionalColumns: map[string]bool{
-		"Activity Task List Partition": taskListType == "Activity",
-		"Decision Task List Partition": taskListType == "Decision",
+		"Activity Task List Partition": taskListType == types.TaskListTypeActivity,
+		"Decision Task List Partition": taskListType == types.TaskListTypeDecision,
 	}})
 }

tools/cli/utils.go

@@ -693,6 +693,8 @@ func parseTimeDuration(duration string) (dur time.Duration, err error) {
 	return
 }
 
+// strToTaskListType converts str to types.TaskListType
+// if it's not matched, it returns types.TaskListTypeDecision
 func strToTaskListType(str string) types.TaskListType {
 	if strings.ToLower(str) == "activity" {
 		return types.TaskListTypeActivity