Handle custom string not equal case for Pinot #6266
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
bowenxia
requested review from
Shaddoll,
neil-xie,
davidporter-id-au,
Groxx,
shijiesheng,
agautam478,
jakobht,
3vilhamster,
sankari165,
dkrotx,
taylanisikdemir and
demirkayaender
as code owners
bowenxia
commented
Sep 5, 2024
| @@ -453,21 +453,22 @@ func processCustomKeyword(operator string, colNameStr string, colValStr string) | |||
| colNameStr, operator, colValStr, colNameStr, operator, colValStr) | |||
| } | |||
|
|
|||
| func processCustomString(comparisonExpr *sqlparser.ComparisonExpr, colNameStr string, colValStr string) string { | |||
| // change to like statement for partial match | |||
| comparisonExpr.Operator = sqlparser.LikeStr | |||
There was a problem hiding this comment.
This part was a legacy code from the first version of pinot_query_validator. Forgot to delete previously.
shijiesheng
reviewed
Sep 5, 2024
Codecov ReportAll modified and coverable lines are covered by tests ✅
Additional details and impacted files
... and 8 files with indirect coverage changes Continue to review full report in Codecov by Sentry.
|
|
@bowenxia it's not super clear to me what the bug actually was (sorry, I may have not had enough context or missed something). Do you mind adding an example of a query that was failing ? |
shijiesheng
approved these changes
Sep 9, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
What changed?
Why?
For example, when search for --query "CustomStringField != 'xxx'", it had the same result as "CustomStringField = 'xxx'"
How did you test it?
Unit test, manually test in QueryBuilder
Potential risks
no
Release notes
Documentation Changes