Skip to content

Add test for cli/admin_timer #6467

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 3 commits into from
Nov 2, 2024
Merged

Add test for cli/admin_timer #6467

merged 3 commits into from
Nov 2, 2024

Conversation

bowenxia
Copy link
Member

@bowenxia bowenxia commented Nov 1, 2024

What changed?

  • Add test for cli/admin_timer
  • Refactor fmt.print to use ioHandler for a better testability

Why?
code coverage week

How did you test it?
unti test

Potential risks

Release notes

Documentation Changes

Copy link

codecov bot commented Nov 1, 2024

Codecov Report

Attention: Patch coverage is 83.33333% with 2 lines in your changes missing coverage. Please review.

Project coverage is 79.77%. Comparing base (a7ce2f6) to head (e3d1dee).
Report is 4 commits behind head on master.

Files with missing lines Patch % Lines
tools/cli/admin_timers.go 77.77% 1 Missing and 1 partial ⚠️
Additional details and impacted files
Files with missing lines Coverage Δ
tools/cli/histogram.go 100.00% <100.00%> (ø)
tools/cli/admin_timers.go 78.60% <77.77%> (+78.60%) ⬆️

... and 12 files with indirect coverage changes


Continue to review full report in Codecov by Sentry.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update a7ce2f6...e3d1dee. Read the comment docs.

@bowenxia bowenxia enabled auto-merge (squash) November 2, 2024 00:46
@bowenxia bowenxia merged commit b6eb4c8 into master Nov 2, 2024
18 of 19 checks passed
@bowenxia bowenxia deleted the xbowen/admin_timer_test_00 branch November 2, 2024 01:22
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants