Skip to content

Tests for AppendHistoryV2Events #6486

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 1 commit into from
Nov 7, 2024
Merged
Changes from all commits
Commits
File filter

Filter by extension

Filter by extension

Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
63 changes: 63 additions & 0 deletions service/history/shard/context_test.go
Original file line number Diff line number Diff line change
Expand Up @@ -685,6 +685,69 @@ func (s *contextTestSuite) TestConflictResolveWorkflowExecution() {
}
}

func (s *contextTestSuite) TestAppendHistoryV2Events() {
cases := []struct {
name string
err error
domainLookupErr error
response *persistence.AppendHistoryNodesResponse
setup func()
asserts func(*persistence.AppendHistoryNodesResponse, error)
}{
{
name: "Success",
response: &persistence.AppendHistoryNodesResponse{},
asserts: func(response *persistence.AppendHistoryNodesResponse, err error) {
s.NoError(err)
s.NotNil(response)
},
},
{
name: "Domain lookup failed",
domainLookupErr: assert.AnError,
asserts: func(resp *persistence.AppendHistoryNodesResponse, err error) {
s.ErrorIs(err, assert.AnError)
},
},
{
name: "History too big",
response: &persistence.AppendHistoryNodesResponse{
DataBlob: persistence.DataBlob{
Data: make([]byte, historySizeLogThreshold+1),
},
},
asserts: func(resp *persistence.AppendHistoryNodesResponse, err error) {
// We do not err on history too big here, we just log it
s.NoError(err)
s.NotNil(resp)
},
},
}

for _, tc := range cases {
s.Run(tc.name, func() {
// Need setup the suite manually, since we are in a subtest
s.SetupTest()
ctx := context.Background()
request := &persistence.AppendHistoryNodesRequest{}
workflowExecution := types.WorkflowExecution{
WorkflowID: testWorkflowID,
RunID: testWorkflowID,
}

s.mockResource.DomainCache.EXPECT().GetDomainName(testDomainID).Return(testDomain, tc.domainLookupErr)
if tc.setup != nil {
tc.setup()
}

s.mockResource.HistoryMgr.On("AppendHistoryNodes", ctx, mock.Anything).Once().Return(tc.response, tc.err)

resp, err := s.context.AppendHistoryV2Events(ctx, request, testDomainID, workflowExecution)
tc.asserts(resp, err)
})
}
}

func (s *contextTestSuite) TestValidateAndUpdateFailoverMarkers() {
domainFailoverVersion := 100
domainCacheEntryInactiveCluster := cache.NewGlobalDomainCacheEntryForTest(
Expand Down
Loading